Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update read-pkg-up usage to work with version 7 #8299

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Oct 5, 2019

What I did

read-pkg-up was updated from version 6 to 7 in a89e02e
But the breaking change explained here https://github.com/sindresorhus/read-pkg-up/releases/tag/v7.0.0 wasn't applied so I just applied it

Not need to backport this fix to 5.2.x as version update was merged in next after 5.3.0-alpha8

`read-pkg-up` was updated from version `6` to `7` in a89e02e
But the breaking change explained here https://github.com/sindresorhus/read-pkg-up/releases/tag/v7.0.0 wasn't applied so I just applied it
@vercel
Copy link

vercel bot commented Oct 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-usage-of-read-pkg-up.storybook.now.sh

@ndelangen ndelangen merged commit 61cd6cd into next Oct 5, 2019
@ndelangen ndelangen deleted the fix-usage-of-read-pkg-up branch October 5, 2019 08:16
@gaetanmaisse
Copy link
Member Author

Thanks @ndelangen, so fast! 🚀

@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Oct 6, 2019
shilman pushed a commit that referenced this pull request Oct 7, 2019
Update `read-pkg-up` usage to work with version `7`
@shilman shilman removed patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Oct 7, 2019
shilman added a commit that referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants