Update Addons-Storysource README.md #8275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the README to explain that changing the parser to Typescript will require updating the Regex test in the custom webpack rule to `tsx` as apposed to `jsx`.
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-lucas-burdell-karmak-patch-2.storybook.now.sh |
shilman
added
addon: storysource
documentation
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Oct 7, 2019
Update Addons-Storysource README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the README to explain that changing the parser to Typescript will require updating the Regex test in the custom webpack rule to
tsxas apposed tojsx.Issue:
The README does not mention changing the regex rule for the webpack config when changing parser type, and the example doesn't have a changed rule (and so won't work with most Typescript projects).
What I did
N/A
How to test
N/A