Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix enableShortcuts option #7990

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Conversation

atanasster
Copy link
Member

@atanasster atanasster commented Sep 4, 2019

Issue: #6569

What I did

if options.enableShortcuts is set to false:

  • remove the display of the shortcuts next to the menu items
  • disable handling of shortcut activities

tried to disturb the existing code as little as possible.

How to test

Please review if indeed all the features should be disabled in shortcuts.ts after the line switch (feature) {

in official storybook, change the

addParameters({
  options: {
    ...
    enableShortcuts: false,
  },
});

NB the options seem to take some time until the local storage expires, so you might have to delete the local storage @storybook/ui/store

@vercel
Copy link

vercel bot commented Sep 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@shilman shilman added this to the 5.2.0 milestone Sep 4, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants