Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/app marionette js #7981

Merged
merged 13 commits into from
Jan 20, 2020
Merged

Add/app marionette js #7981

merged 13 commits into from
Jan 20, 2020

Conversation

avasuro
Copy link
Contributor

@avasuro avasuro commented Sep 3, 2019

Issue: #7980

What I did

Added support of Marionette.js framework

How to test

  • Is this testable with Jest or Chromatic screenshots? - don't know, done similar as html app
  • Does this need a new example in the kitchen sink apps? - don't know
  • Does this need an update to the documentation? - done (I think)

@vercel
Copy link

vercel bot commented Sep 3, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/fdy0zpysi
✅ Preview: https://monorepo-git-fork-avasuro-add-appmarionette-js.storybook.now.sh

@shilman shilman added this to the 5.3.0 milestone Sep 3, 2019
@shilman
Copy link
Member

shilman commented Sep 3, 2019

Great work @avasuro -- very exciting! We're just getting 5.2 out the door, so we'll have to wait until that's released to merge this.

@avasuro
Copy link
Contributor Author

avasuro commented Sep 4, 2019

@shilman, thank you! no problem.

ndelangen
ndelangen approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a example for this?

README.md Outdated Show resolved Hide resolved
@ndelangen ndelangen removed the request for review from stijnkoopal September 5, 2019 09:36
@avasuro
Copy link
Contributor Author

avasuro commented Sep 5, 2019

I think yes, for consistency (all other frameworks except react native has examples). But I didn't figured out how to do that.

@ndelangen ndelangen self-assigned this Sep 25, 2019
@ndelangen
Copy link
Member

@avasuro shall we schedule a pair programming session to finish this?

contact me on discord:
https://discord.gg/sMFvFsG

We need to add an example of a marionette app that has storybook.

@ndelangen
Merge branch 'next' into pr/avasuro/7981
3a9d2f8 
# Conflicts:
#	lib/cli/package.json
#	yarn.lock
@ndelangen
Copy link
Member

@avasuro do you think you'd be available to work together on this to get this merged?

@avasuro
Copy link
Contributor Author

avasuro commented Oct 22, 2019

@ndelangen

Hi, yes. I will write you in discord.

@shilman shilman modified the milestones: 5.3.0, 5.4.0 Nov 13, 2019
@shilman shilman modified the milestones: 5.4.0, 6.0.0 Dec 16, 2019
@ndelangen ndelangen merged commit a3cd026 into storybookjs:next Jan 20, 2020
@shilman shilman mentioned this pull request Jan 21, 2020
Closed
This was referenced Feb 24, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman Awaiting requested review from shilman

@tmeasday tmeasday Awaiting requested review from tmeasday

@alterx alterx Awaiting requested review from alterx

@dangreenisrael dangreenisrael Awaiting requested review from dangreenisrael

@igor-dv igor-dv Awaiting requested review from igor-dv

@thani-sh thani-sh Awaiting requested review from thani-sh

@theinterned theinterned Awaiting requested review from theinterned

Assignees

@ndelangen ndelangen

Labels
feature request
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@avasuro @shilman @ndelangen