Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Error handling for invalid Story id #7965

Merged
merged 13 commits into from
Sep 4, 2019
Merged

Addon-docs: Error handling for invalid Story id #7965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
66c3753
check for children in Story, added example to add-docs.stories.mdx
atanasster Sep 2, 2019
6d773cb
change story id to "nonexistent-story"
atanasster Sep 3, 2019
e6ee1be
fix for react hooks and invalid story error, added react hooks exampl…
atanasster Sep 3, 2019
7b6c6b4
fixed spelling of 'Invariant Violations'
atanasster Sep 4, 2019
d3a5e4b
added EmptyStory message
atanasster Sep 4, 2019
3e20156
empty story message linking to story id
atanasster Sep 4, 2019
bbd1f5a
fixed comment style for linting
atanasster Sep 4, 2019
d3a50f2
Misc cleanup
shilman Sep 4, 2019
ef20bea
Add missing story ref to vue-kitchen-sink MDX for QA
shilman Sep 4, 2019
831ecac
cleanup
shilman Sep 4, 2019
af6c86a
removed storyFn call as a function completely
atanasster Sep 4, 2019
74385e7
Merge branch 'mdx-empty-story' of https://github.com/atanasster/story…
atanasster Sep 4, 2019
cb87c56
simplified code
atanasster Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/official-storybook/stories/addon-docs/addon-docs.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ import DocgenButton from '../../components/DocgenButton';

<Props of="." />

<Preview>
<Story id="empty-story" />
shilman marked this conversation as resolved.
Show resolved Hide resolved
</Preview>

## A random color ColorPalette

<ColorPalette>
Expand Down
5 changes: 4 additions & 1 deletion lib/components/src/blocks/Story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,14 @@ const IFrameStory: React.FunctionComponent<IFrameStoryProps> = ({
const Story: React.FunctionComponent<StoryProps> = props => {
const { error } = props as ErrorProps;
const { storyFn } = props as InlineStoryProps;
const { id, inline, title, height } = props;
const { id, inline, title, height, children } = props;

if (error) {
return <EmptyBlock>{error}</EmptyBlock>;
}
if (!children) {
atanasster marked this conversation as resolved.
Show resolved Hide resolved
return <EmptyBlock>{StoryError.NO_STORY}</EmptyBlock>;
}
return inline ? (
<InlineStory id={id} storyFn={storyFn} title={title} height={height} />
) : (
Expand Down