Remember width of down panel when it's displayed on right #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix a typo error in example readme
ndelangen
approved these changes
Apr 17, 2017
willowcheng
changed the title
|
Hey @willowcheng, Thanks for this PR! We changed from a fork of react-split-view to the original version, so some things have changed. Could you have a look and possibly resolve the merge conflicts that have arisen because of this? Let me know if you need anything, 🙇 |
|
Hi @ndelangen, I think #956 already fixed my concern in a better way for this PR 😃, and it can be closed now. |
|
Ok awesome, thanks anyway! |
|
View your CI Pipeline Execution ↗ for commit c46464c.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: storybook-eol/storybook-ui#62
What I did
Enable localStorage to remember position for both displaying down panel on bottom or right.
(Carried over from storybook-eol/storybook-ui#80)
How to test
Follow
storybook-ui/example/README.mdto manual test, should be able to inspect changes in Local Storage from browser developer tool.