Migrate @storybook/addon-ondevice-notes to Typescript #7737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-lonyele-feature-migrate-ondevice-notes-to-ts.storybook.now.sh |
|
Automention: Hey @emilio-martinez @gaetanmaisse @kroeder @ndelangen, you've been tagged! Can you give a hand here? |
gaetanmaisse
approved these changes
Aug 12, 2019
|
@lonyele I just updated your PR description to follow what @shilman suggested here: #5030 (comment) |
|
@gaetanmaisse Oh thanks! I also updated the status for these PRs at #5030 |
lonyele
requested review from
aaronmcadam,
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
danielduan,
Gongreg,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
naipath,
ndelangen and
renaudtertrais
as code owners
lonyele
requested review from
gaetanmaisse
and removed request for
aaronmcadam,
alexandrebodin,
naipath,
igor-dv,
z4o4z,
rmevans9,
usulpro,
CodeByAlex,
alterx,
dangreenisrael,
danielduan,
Gongreg,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
renaudtertrais,
saponifi3d,
stijnkoopal,
thomasbertet and
tmeasday
# Conflicts: # addons/ondevice-notes/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
It's small but better than nothing...
How to test
Tracking Issue: #5030