Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate @storybook/addon-ondevice-backgrounds to Typescript #7736

Merged
merged 10 commits into from
Sep 27, 2019
Merged

Migrate @storybook/addon-ondevice-backgrounds to Typescript #7736

merged 10 commits into from
Sep 27, 2019

Conversation

lonyele
Copy link
Member

@lonyele lonyele commented Aug 10, 2019 •
edited by gaetanmaisse
Loading

What I did

I migrated addon-ondevice-backgrounds to Typescript

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

Tracking Issue: #5030

@vercel
Copy link

vercel bot commented Aug 10, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-lonyele-feature-migrate-ondevice-88e14e.storybook.now.sh

@vercel vercel bot temporarily deployed to staging August 10, 2019 16:56 Inactive
@lonyele lonyele added addon: backgrounds maintenance User-facing maintenance tasks typescript labels Aug 10, 2019
@shilman shilman added this to the 5.3.0 milestone Aug 12, 2019
@github-actions
Copy link
Contributor

Automention: Hey @emilio-martinez @gaetanmaisse @kroeder @ndelangen, you've been tagged! Can you give a hand here?

@kroeder kroeder mentioned this pull request Aug 13, 2019
Closed
@ndelangen ndelangen self-assigned this Sep 27, 2019
@ndelangen ndelangen merged commit 38ffc6a into storybookjs:next Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaetanmaisse gaetanmaisse gaetanmaisse approved these changes

@shilman shilman Awaiting requested review from shilman

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees

@ndelangen ndelangen

Labels
addon: backgrounds maintenance User-facing maintenance tasks typescript
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lonyele @gaetanmaisse @shilman @ndelangen