Addon-docs: DocsPage slots for fine-grained user control #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-7456-docspage-slots.storybook.now.sh |
tmeasday
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7456
What I did
First cut at a "slots" feature for fine-grained control of what shows up on DocsPage, with sensible defaults.
What can be controlled:
Technically this is a breaking change because it modifies a public API. However, it's a mostly undocumented API that I don't expect anybody to use, and it's still beta. If you just used
DocsPageout of the box, this change should be fully backwards-compatible.How to test
See my update to
official-storybook/config.jsfor an example usage