Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGE define plugin variables to globals instead #7622

Merged
merged 3 commits into from
Jul 30, 2019
Merged

CHANGE define plugin variables to globals instead #7622

merged 3 commits into from
Jul 30, 2019

Conversation

ndelangen
Copy link
Member

Issue: #7024

What I did

I moved the 2 variables from being code-injected by webpack to being injected into the global app runtime via the template

@shilman

@ndelangen ndelangen added this to the 5.2.0 milestone Jul 30, 2019
@ndelangen ndelangen self-assigned this Jul 30, 2019
@vercel
Copy link

vercel bot commented Jul 30, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-tech-change-defineplugin-globals.storybook.now.sh

@vercel vercel bot temporarily deployed to staging July 30, 2019 12:30 Inactive
shilman
shilman approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. 🚀 Thanks for taking care of this!!

@ndelangen ndelangen merged commit ebaf856 into next Jul 30, 2019
@ndelangen ndelangen deleted the tech/change-defineplugin-globals branch July 30, 2019 23:12
@shilman shilman mentioned this pull request Jul 31, 2019
Closed
2 tasks
@lonyele lonyele mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
addon: docs bug ui
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman