Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running storybook examples #7506

Closed
wants to merge 1 commit into from

Conversation

lonyele
Copy link
Member

@lonyele lonyele commented Jul 20, 2019

Issue: #7505

What I did

I added --no-dll option to start-storybook command. angular-cli has noda-sass problem aside from this one so I didn't include it in this PR.

@vercel
Copy link

vercel bot commented Jul 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-lonyele-fix-example-start.storybook.now.sh

@lonyele
Copy link
Member Author

lonyele commented Jul 20, 2019

Hm... I don't know how to fix for angular-cli example. I read #2994 or #5684, but I'll leave it for others...

@shilman
Copy link
Member

shilman commented Jul 20, 2019

@lonyele are you on our Discord? I'd love to chat with you when you have a minute https://discord.gg/UUt2PJb

@lonyele
Copy link
Member Author

lonyele commented Jul 21, 2019

@shilman Oh, I went to bed early yesterday and... woke up around 4pm hahaha. I'm in Korea so I'm available at that time zone. I'm on both Discord and Slack btw.

@ndelangen
Copy link
Member

Is this still needed? I'd rather keep the examples using the DLL to ensure the dll works.

@shilman
Copy link
Member

shilman commented Jul 23, 2019

@ndelangen we need to fix the webpack define for PREVIEW_URL And DOCS_MODE to get it working without --no-dll

@ndelangen
Copy link
Member

Yea we have to change that to a global in the template variables IMHO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants