Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log loading angular cli config error #7484

Merged
merged 4 commits into from
Jul 24, 2019
Merged

chore: log loading angular cli config error #7484

merged 4 commits into from
Jul 24, 2019

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jul 19, 2019

It would be mush more helpful for users to check why the config is not loaded successfully

Issue:

What I did

Just add log info for loading angular cli config error

How to test

  • Is this testable with Jest or Chromatic screenshots?
    Not needed

  • Does this need a new example in the kitchen sink apps?
    Not needed

  • Does this need an update to the documentation?
    Not needed

If your answer is yes to any of these, please make sure to include it in your PR.

@JounQin JounQin requested review from alterx and igor-dv as code owners July 19, 2019 04:12
@vercel
Copy link

vercel bot commented Jul 19, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-jounqin-chore-tracengclierror.storybook.now.sh

@vercel vercel bot temporarily deployed to staging July 19, 2019 04:33 Inactive
JounQin added 2 commits July 19, 2019 12:33
It would be mush more helpful for users to check why the config is not loaded successfully
@vercel vercel bot temporarily deployed to staging July 24, 2019 08:40 Inactive
Copy link
Member

@kroeder kroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kroeder kroeder added the maintenance User-facing maintenance tasks label Jul 24, 2019
@shilman shilman merged commit a089555 into storybookjs:next Jul 24, 2019
@JounQin JounQin deleted the chore/trace_ng_cli_error branch July 24, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants