Migrate @storybook/html to Typescript #7338
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-emilio-martinez-ts-migration-storybook-html.storybook.now.sh |
emilio-martinez
force-pushed
the
ts-migration/storybook-html
branch
from
bfd9c11 to
5e38f19
Compare
emilio-martinez
requested review from
Hypnosphi,
kroeder,
gaetanmaisse and
ndelangen
| @@ -1,4 +1,7 @@ | |||
| export function webpack(config) { | |||
| // eslint-disable-next-line import/no-extraneous-dependencies | |||
| import { Configuration } from 'webpack'; | |||
There was a problem hiding this comment.
I don't know well how this part of SB is working but maybe webpack should be a peerDependency?
@ndelangen can surely help us with this ;)
There was a problem hiding this comment.
You can create a dependency on webpack for now, in monoconfig, I'll try an consolidate these types into a coherent whole.
When you add the dependency, be sure to add a wide version range.
There was a problem hiding this comment.
I think we should declare all the preset function types in @storybook/core
There was a problem hiding this comment.
Just to clarify, in this case Configuration is being picked up through @types/webpack which is a devDependency at the root of the repo. Technically, there's no runtime use or type definitions coming from webpack here.
It would make sense to add @types/webpack as a devDependency here—I could match the version at the root of the repo to avoid any conflicts. Given the above, do you guys still feel I should add webpack as a dependency? Let me know your thoughts 😄
There was a problem hiding this comment.
@gaetanmaisse @ndelangen let me know your thoughts on my last comment and I'll make the change :)
|
I recently did some work on app/react & app/angular Those are now typescript as well. Would be great if this PR would follow those examples. |
emilio-martinez
force-pushed
the
ts-migration/storybook-html
branch
from
5e38f19 to
c70c1a9
Compare
|
@ndelangen latest commit is up for you to take a look—rebased against |
Issue: #5030
What I did
Migrate @storybook/html to Typescript
How to test
Everything should function the same, except the package should now have type definitions.
Note: The first commit is intentionally mostly a rename from js => ts to make the review easier via the subsequent commits.