TS migrate: lib/client-api + app/angular + app/react + dependency upgrades #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsc wants all imports to be under rootDir
# Conflicts: # app/angular/src/client/preview/index.js # yarn.lock
# Conflicts: # docs/package.json # docs/src/versions/next.json # lib/client-api/src/client_api.ts
backbone87
reviewed
Jul 8, 2019
# Conflicts: # addons/knobs/src/components/Panel.tsx # addons/knobs/src/components/types/Checkboxes.js # addons/knobs/src/components/types/Files.js # addons/knobs/src/components/types/Options.js # app/angular/package.json # app/react/package.json # lib/cli/lib/initiate.js # lib/client-api/src/story_store.ts # lib/components/package.json # lib/components/src/blocks/Preview.tsx # lib/ui/src/components/layout/container.js # lib/ui/src/components/sidebar/treeview/treeview.js # lib/ui/src/index.js # scripts/bootstrap.js # yarn.lock
backbone87
reviewed
Jul 9, 2019
lib/addons/src/types.ts
Outdated
| export interface Parameters { | ||
| fileName?: string; | ||
| options?: OptionsParameter; | ||
| [key: string]: any; |
There was a problem hiding this comment.
do we really want to allow this wildcard?
addons can argument this interface to add their own params.
the same question applies to StoryContext
There was a problem hiding this comment.
Yeah these are extensible by design.
There was a problem hiding this comment.
i think we missunderstand.
export interface Parameters {
fileName?: string;
options?: OptionsParameter;
}is just as extensible when using interface augmentation, it just doesnt allow untyped params (because no index signature). see https://www.typescriptlang.org/docs/handbook/declaration-merging.html#merging-interfaces
backbone87
reviewed
Jul 9, 2019
backbone87
reviewed
Jul 9, 2019
# Conflicts: # app/angular/package.json # app/react/package.json # app/react/src/client/preview/types.ts # jest.config.js # lib/addons/src/make-decorator.ts # lib/components/package.json # scripts/compile-babel.js # yarn.lock
|
I merged the PRs individually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combines #7147 & #6570