Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix --preview-url for static builds #7245

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 1, 2019

Issue: #5975

What I did

Fixed a bug where the previewUrl wasn't getting passed through on static build.

How to test

Run examples/standalone-preview in one terminal, then:

cd examples/cra-kitchen-sink
yarn build-storybook --preview-url=http://localhost:1337/iframe.html

@vercel
Copy link

vercel bot commented Jul 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-5975-static-build-preview-url.storybook.now.sh

@shilman shilman changed the title Fix --preview-url on static build CLI: Fix --preview-url for static builds Jul 1, 2019
@shilman shilman changed the title CLI: Fix --preview-url for static builds CLI: Fix --preview-url for static builds Jul 1, 2019
@shilman shilman added this to the 5.2.0 milestone Jul 1, 2019
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 9835ab9 into next Jul 2, 2019
@shilman shilman deleted the 5975-static-build-preview-url branch July 2, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants