Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate addon viewport to TS #7177

Merged
merged 3 commits into from
Jun 25, 2019
Merged

Migrate addon viewport to TS #7177

merged 3 commits into from
Jun 25, 2019

Conversation

gaetanmaisse
Copy link
Member

Issue: #5030

What I did

  • Migrate @storybook/addon-viewport to TypeScript
  • Refactor some imports/exports
  • Add some types and interfaces and use them to type codebase

@vercel
Copy link

vercel bot commented Jun 24, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-ts-migration-addon-viewport.storybook.now.sh

@vercel vercel bot temporarily deployed to staging June 24, 2019 18:55 Inactive
@gaetanmaisse gaetanmaisse added addon: viewport maintenance User-facing maintenance tasks labels Jun 24, 2019
@gaetanmaisse
Copy link
Member Author

@ndelangen I think chromatic is ok but not sure, can you take a look at the 7 remainings changes? They are all linked to a new viewMode attribute added in DOM

@ndelangen ndelangen merged commit c61dfb7 into next Jun 25, 2019
@ndelangen ndelangen deleted the ts-migration/addon-viewport branch June 25, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: viewport maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants