Migrate @storybook/addon-graphql to typescript #6935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-lonyele-feature-migrate-addon-graphql-to-ts.storybook.now.sh |
shilman
added
addon: graphql
maintenance
gaetanmaisse
approved these changes
Jun 3, 2019
|
@lonyele great PR, well split in multiple commits and so easy to review, I just added a few minors comments. 👏 |
ndelangen
approved these changes
Jun 3, 2019
gaetanmaisse
approved these changes
Jun 3, 2019
|
@gaetanmaisse Thanks for your review. I hopefully make better one next time. |
|
FYI will merge this after 5.1 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5030
What I did
@storybook/addon-graphqlto typescript.I asked discord's typescript channel about the contribution. It seems like no one has been working on this addon so I took this one. It is not on the priority list but it looks like a good starter for me. It is my first time migrating to typescript here, so please give me some feedbacks. I'll apply it.