Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jest design changes #6847

Merged
merged 3 commits into from
Jun 4, 2019

Conversation

CodeByAlex
Copy link
Member

Issue: #6805

What I did

I moved the name of the test class above the progress bar, moved the passing percentage below the progress bar, and increased contrast in the error message box.

Original:
image

New:
image

How to test

  • Is this testable with Jest or Chromatic screenshots? yes
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

Verified

This commit was signed with the committer’s verified signature.
Kielek Piotr Kiełkowicz
…ress bar and moved the title above the rest of the content
@CodeByAlex CodeByAlex added addon: jest patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 21, 2019
@vercel
Copy link

vercel bot commented May 21, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-codebyalex-feature-jest-design-changes.storybook.now.sh

@CodeByAlex CodeByAlex added bug and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 21, 2019
@ndelangen ndelangen added this to the 5.2.0 milestone May 22, 2019
@ndelangen
Copy link
Member

Feel free to change it in more radical ways, and extracting the re-usable component into lib/components 👍

@ndelangen
Copy link
Member

It would also be great to actually have stories for this component, so we don't have to paste screengrabs, but can approve with chromatic 👍

@shilman shilman modified the milestones: 5.2.0, 5.1.x, 5.1.0 Jun 4, 2019
@shilman shilman merged commit 8792884 into storybookjs:next Jun 4, 2019
@shilman shilman mentioned this pull request Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants