Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lodash to latest #6832

Merged
merged 4 commits into from
May 20, 2019

Conversation

Stephanemw
Copy link
Contributor

Issue:

  • Lodash modularised is OOOOoold. And has two CVEs listed against it. This prevents SB from being used by some developers with risk-averse corporate development environments.

What I did

  • Updated lodash dependencies to latest ^4.17.11
  • Touched up imports to use latest tree-shakeable lodash dependency format
  • Added no-restricted-imports rules to eslint config

How to test

Tested using test core & image (test cli fails on adding sb to marko with 'EACCES: permission denied'?)

…ee-shakeable ones, add restricted packages eslint rules to avoid lodash modularised usage in future
@vercel
Copy link

vercel bot commented May 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-stephanemw-upgrade-lodash-to-latest.storybook.now.sh

@ndelangen ndelangen added this to the 5.1.0 milestone May 20, 2019
@ndelangen ndelangen self-assigned this May 20, 2019
…ration of lockfile within project of yarn workspace
@vercel vercel bot temporarily deployed to staging May 20, 2019 13:01 Inactive
@ndelangen ndelangen merged commit 5994174 into storybookjs:next May 20, 2019
@Stephanemw Stephanemw deleted the upgrade-lodash-to-latest branch May 20, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants