Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD addon-contexts: Preact support #6660

Merged
merged 5 commits into from
Apr 27, 2019
Merged

Conversation

leoyli
Copy link
Contributor

@leoyli leoyli commented Apr 27, 2019

Issue: #6659

What I did

  • [feature] Add Support to Preact.
  • [doc] Update addon support list and example stories into Preact-kitchen-sink.
  • [doc] Update README.md file for redirect the reader on the framework support table.

Note, currently Preact only support the old context API. The new createContext API is just released in Preact X beta.0; therefore, I add a TODO and comment out the Language example story for Preact (to avoid foreseeable to-be-out-dated works).

How to test

Live Example:
https://monorepo-git-add-addon-contextspreact-support.storybook.now.sh/examples/preact-kitchen-sink/?path=/story/addons-contexts--simple-css-theming&contexts=CSS%20Themes=Forest

@vercel
Copy link

vercel bot commented Apr 27, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-add-addon-contextspreact-support.storybook.now.sh

@vercel vercel bot temporarily deployed to staging April 27, 2019 02:28 Inactive
@leoyli leoyli requested review from ndelangen and shilman April 27, 2019 02:30
@vercel vercel bot temporarily deployed to staging April 27, 2019 02:37 Inactive
@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #6660 into next will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##            next    #6660      +/-   ##
=========================================
- Coverage   40.4%   40.38%   -0.03%     
=========================================
  Files        637      639       +2     
  Lines       8778     8783       +5     
  Branches     643      643              
=========================================
  Hits        3547     3547              
- Misses      5133     5138       +5     
  Partials      98       98
Impacted Files Coverage Δ
addons/contexts/src/preview/frameworks/preact.ts 0% <0%> (ø)
...ddons/contexts/src/shared/@mock-types/_preact.d.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d3878...1ae1e5e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #6660 into next will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##            next    #6660      +/-   ##
=========================================
- Coverage   40.4%   40.38%   -0.03%     
=========================================
  Files        637      639       +2     
  Lines       8778     8783       +5     
  Branches     643      643              
=========================================
  Hits        3547     3547              
- Misses      5133     5138       +5     
  Partials      98       98
Impacted Files Coverage Δ
addons/contexts/src/preview/frameworks/preact.ts 0% <0%> (ø)
...ddons/contexts/src/shared/@mock-types/_preact.d.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d3878...1ae1e5e. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @leoyli !! 🎉

@leoyli leoyli marked this pull request as ready for review April 27, 2019 03:38
@leoyli leoyli merged commit cc7f44c into next Apr 27, 2019
@leoyli leoyli deleted the add/addon-contexts/preact-support branch April 27, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants