-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD addon-contexts: Preact support #6660
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-add-addon-contextspreact-support.storybook.now.sh |
Codecov Report
@@ Coverage Diff @@
## next #6660 +/- ##
=========================================
- Coverage 40.4% 40.38% -0.03%
=========================================
Files 637 639 +2
Lines 8778 8783 +5
Branches 643 643
=========================================
Hits 3547 3547
- Misses 5133 5138 +5
Partials 98 98
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## next #6660 +/- ##
=========================================
- Coverage 40.4% 40.38% -0.03%
=========================================
Files 637 639 +2
Lines 8778 8783 +5
Branches 643 643
=========================================
Hits 3547 3547
- Misses 5133 5138 +5
Partials 98 98
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @leoyli !! 🎉
Issue: #6659
What I did
Note, currently Preact only support the old context API. The new createContext API is just released in Preact X beta.0; therefore, I add a TODO and comment out the
Language
example story for Preact (to avoid foreseeable to-be-out-dated works).How to test
Live Example:
https://monorepo-git-add-addon-contextspreact-support.storybook.now.sh/examples/preact-kitchen-sink/?path=/story/addons-contexts--simple-css-theming&contexts=CSS%20Themes=Forest