Upgrade to core-js v3 #6655
Merged
Upgrade to core-js v3 #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armandabric
requested review from
aaronmcadam,
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
danielduan,
Gongreg,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
naipath,
ndelangen,
renaudtertrais,
saponifi3d,
shilman,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-spy-seth-upgrade-to-core-js-v3.storybook.now.sh |
# Conflicts: # addons/actions/package.json # addons/backgrounds/package.json # addons/cssresources/package.json # addons/events/package.json # addons/google-analytics/package.json # addons/info/package.json # addons/jest/package.json # addons/notes/package.json # addons/ondevice-backgrounds/package.json # addons/ondevice-knobs/package.json # addons/ondevice-notes/package.json # addons/options/package.json # addons/storyshots/storyshots-core/package.json # addons/storyshots/storyshots-puppeteer/package.json # addons/storysource/package.json # addons/viewport/package.json # lib/addons/package.json # lib/api/package.json # lib/channel-postmessage/package.json # lib/channel-websocket/package.json # lib/components/package.json # lib/router/package.json # lib/ui/package.json # yarn.lock
ndelangen
approved these changes
May 6, 2019
benoitdion
reviewed
May 6, 2019
| "OBJECT_VALUE_BOOLEAN_COLOR": "rgb(28, 0, 207)", | ||
| "OBJECT_VALUE_FUNCTION_KEYWORD_COLOR": "rgb(170, 13, 145)", | ||
| "OBJECT_VALUE_FUNCTION_PREFIX_COLOR": "rgb(13, 34, 170)", |
There was a problem hiding this comment.
are these changes the result of something else?
There was a problem hiding this comment.
I don't really know TBH, I just updated the snapshots
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
# Conflicts: # lib/router/package.json # yarn.lock
|
This has broken the dll in my branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Following the discussion in #6589, this PR upgrade core-js to v3. It will help to upgrade the webpack CRA preset to match the CRA v3 release
I use the work done in #6566 as guide
I think this should be considered as breaking change: it could lead to some behavior change on CRA storybook.