-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS improve registration in VueJs guide #6608
DOCS improve registration in VueJs guide #6608
Conversation
This pull request is automatically deployed with Now. |
Codecov Report
@@ Coverage Diff @@
## next #6608 +/- ##
==========================================
+ Coverage 40.57% 40.61% +0.03%
==========================================
Files 637 633 -4
Lines 8714 8660 -54
Branches 625 620 -5
==========================================
- Hits 3536 3517 -19
+ Misses 5089 5054 -35
Partials 89 89
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @elevatebart 👏
Made a few tweaks FYI:
- Edited the description
Isuse: #xxx
- Added the
patch
label because it's a doc update that needs to get merged back intomaster
to be deployed (if it was5.1
-specific docs I wouldn't add it)
DOCS improve registration in VueJs guide
Issue: #6357
What I did
Following issue #6357, I added a
<details>
section to the vue guide, to signal the need for global registration if the stories return plain text.I added a JSX solution as well.
How to test
Read the docs on zeit