Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS improve registration in VueJs guide #6608

Merged
merged 6 commits into from
Apr 24, 2019
Merged

DOCS improve registration in VueJs guide #6608

merged 6 commits into from
Apr 24, 2019

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Apr 24, 2019

Issue: #6357

What I did

Following issue #6357, I added a <details> section to the vue guide, to signal the need for global registration if the stories return plain text.

I added a JSX solution as well.

How to test

Read the docs on zeit

@vercel vercel bot temporarily deployed to staging April 24, 2019 13:49 Inactive
@vercel
Copy link

vercel bot commented Apr 24, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot temporarily deployed to staging April 24, 2019 13:55 Inactive
@vercel vercel bot temporarily deployed to staging April 24, 2019 14:01 Inactive
@vercel vercel bot temporarily deployed to staging April 24, 2019 14:05 Inactive
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #6608 into next will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6608      +/-   ##
==========================================
+ Coverage   40.57%   40.61%   +0.03%     
==========================================
  Files         637      633       -4     
  Lines        8714     8660      -54     
  Branches      625      620       -5     
==========================================
- Hits         3536     3517      -19     
+ Misses       5089     5054      -35     
  Partials       89       89
Impacted Files Coverage Δ
addons/contexts/src/preview/libs/getPropsMap.ts 100% <0%> (ø) ⬆️
...ddons/contexts/src/preview/libs/getContextNodes.ts 100% <0%> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarStories.js 100% <0%> (ø) ⬆️
addons/contexts/src/index.ts 0% <0%> (ø) ⬆️
...ddons/contexts/src/preview/libs/getRendererFrom.ts 100% <0%> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarHeading.js 88.88% <0%> (ø) ⬆️
lib/components/src/tooltip/WithTooltip.tsx 25% <0%> (ø) ⬆️
addons/contexts/src/manager/libs/useChannel.ts 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 29.62% <0%> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarItem.js 96% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97fbbc0...45e7b4b. Read the comment docs.

@vercel vercel bot temporarily deployed to staging April 24, 2019 14:07 Inactive
@elevatebart elevatebart self-assigned this Apr 24, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 24, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @elevatebart 👏

Made a few tweaks FYI:

  • Edited the description Isuse: #xxx
  • Added the patch label because it's a doc update that needs to get merged back into master to be deployed (if it was 5.1-specific docs I wouldn't add it)

@shilman shilman merged commit 2f9a727 into storybookjs:next Apr 24, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 28, 2019
shilman added a commit that referenced this pull request Apr 28, 2019
DOCS improve registration in VueJs guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants