Check for color knob value existence before applying uppercase #6598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binomialstew
requested review from
alexandrebodin,
alterx,
leonrodenburg and
theinterned
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-binomialstew-bugfix-6597.storybook.now.sh |
shilman
added
addon: knobs
bug
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Apr 28, 2019
Check for color knob value existence before applying uppercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6597
What I did
Fixes #6597
How to test
https://github.com/storybooks/storybook/blob/c6d704225eec98c20a729242f14987852071ddb1/examples/official-storybook/stories/addon-knobs.stories.js#L65
["bug"]