Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #6338: Changed default value for sourceMap property of angulars webpack config #6535

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

aspidov
Copy link
Contributor

@aspidov aspidov commented Apr 16, 2019

Issue: #6338

What I did

changed value of sourceMap from {} to false

How to test

Create a project via latest angular-cli and add storybook, it will fail, because sourceMap property should be boolean

@vercel
Copy link

vercel bot commented Apr 16, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-aspidov-next.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aspidov Is this backwards compatible? If so, how far back?

@shilman shilman added angular bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 16, 2019
@shilman shilman added this to the 5.0.x milestone Apr 16, 2019
@aspidov
Copy link
Contributor Author

aspidov commented Apr 16, 2019

@shilman , this property was itroduced in this commit angular/angular-cli@cde624a#diff-dffa709a67c66e298beea219faae843fR595 , and always was boolean. So yes, this is backwards compatible.

@aspidov
Copy link
Contributor Author

aspidov commented Apr 17, 2019

@igor-dv @kroeder @shilman please let me know if you need any additional information.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #6535 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6535   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files         616      616           
  Lines        8525     8525           
  Branches      595      595           
=======================================
  Hits         3478     3478           
  Misses       4955     4955           
  Partials       92       92
Impacted Files Coverage Δ
app/angular/src/server/angular-cli_config.js 39.53% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b06bf...d6ac3d4. Read the comment docs.

@ndelangen
Copy link
Member

@yjcxy12 According to git you added this line, would you be able to pitch in here and see if the proposed change is correct too?

@ndelangen ndelangen merged commit e887de7 into storybookjs:next Apr 18, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 28, 2019
shilman pushed a commit that referenced this pull request Apr 28, 2019
Fix for issue #6338: Changed default value for sourceMap property of angulars webpack config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants