-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #6338: Changed default value for sourceMap property of angulars webpack config #6535
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-aspidov-next.storybook.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aspidov Is this backwards compatible? If so, how far back?
@shilman , this property was itroduced in this commit angular/angular-cli@cde624a#diff-dffa709a67c66e298beea219faae843fR595 , and always was boolean. So yes, this is backwards compatible. |
Codecov Report
@@ Coverage Diff @@
## next #6535 +/- ##
=======================================
Coverage 40.79% 40.79%
=======================================
Files 616 616
Lines 8525 8525
Branches 595 595
=======================================
Hits 3478 3478
Misses 4955 4955
Partials 92 92
Continue to review full report at Codecov.
|
@yjcxy12 According to git you added this line, would you be able to pitch in here and see if the proposed change is correct too? |
Fix for issue #6338: Changed default value for sourceMap property of angulars webpack config
Issue: #6338
What I did
changed value of sourceMap from {} to false
How to test
Create a project via latest angular-cli and add storybook, it will fail, because sourceMap property should be boolean