Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up theming docs #6494

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Clean up theming docs #6494

merged 2 commits into from
Apr 19, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 12, 2019

Issue: N/A

What I did

Tighten up the intro to theming

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch theming labels Apr 12, 2019
@shilman shilman requested a review from ndelangen as a code owner April 12, 2019 05:09
@vercel
Copy link

vercel bot commented Apr 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-clean-up-theming-docs.storybook.now.sh

@shilman shilman requested a review from domyen April 12, 2019 05:09
@shilman shilman added this to the 5.0.x milestone Apr 12, 2019
@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #6494 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6494   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files         616      616           
  Lines        8518     8518           
  Branches      535      535           
=======================================
  Hits         3477     3477           
  Misses       4949     4949           
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b6192...4f9ca85. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #6494 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            next   #6494   +/-   ##
=====================================
  Coverage   40.1%   40.1%           
=====================================
  Files        633     633           
  Lines       8659    8659           
  Branches     619     619           
=====================================
  Hits        3473    3473           
  Misses      5097    5097           
  Partials      89      89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a15a14...504cb26. Read the comment docs.

@ndelangen ndelangen merged commit 6c37474 into next Apr 19, 2019
@ndelangen ndelangen deleted the fix/clean-up-theming-docs branch April 19, 2019 20:19
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 28, 2019
shilman pushed a commit that referenced this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants