Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #6477

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Fix typo #6477

merged 1 commit into from
Apr 11, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 10, 2019

Issue: #6430

What I did

Fix react-docgen-typescript-loader installation to match usage below

@shilman shilman added configuration babel / webpack documentation patch:yes Bugfix & documentation PR that need to be picked to main branch typescript labels Apr 10, 2019
@shilman shilman added this to the 5.0.x milestone Apr 10, 2019
@shilman shilman requested a review from ndelangen as a code owner April 10, 2019 07:17
@vercel
Copy link

vercel bot commented Apr 10, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-typeescript-configur.storybook.now.sh

@codecov
Copy link

codecov bot commented Apr 11, 2019 •
edited
Loading

Codecov Report

Merging #6477 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6477   +/-   ##
=======================================
  Coverage   40.76%   40.76%           
=======================================
  Files         612      612           
  Lines        8478     8478           
  Branches      535      535           
=======================================
  Hits         3456     3456           
  Misses       4930     4930           
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f4abf...99375c9. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #6477 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6477   +/-   ##
=======================================
  Coverage   40.76%   40.76%           
=======================================
  Files         612      612           
  Lines        8478     8478           
  Branches      535      535           
=======================================
  Hits         3456     3456           
  Misses       4930     4930           
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f4abf...99375c9. Read the comment docs.

@ndelangen ndelangen merged commit 570a0d1 into next Apr 11, 2019
@ndelangen ndelangen deleted the fix/typeescript-configuration-typo branch April 11, 2019 12:19
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
configuration babel / webpack documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch typescript
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @ndelangen