Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CRA React15 example to test back-compat #6475

Merged
merged 24 commits into from
May 7, 2019
Merged

Add CRA React15 example to test back-compat #6475

merged 24 commits into from
May 7, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 10, 2019 •
edited
Loading

Issue: #6474

What I did

Added an example using react15 to the repo to demonstrate a problem with theming

How to test

yarn bootstrap --reset --core
cd examples/creact-cra15
yarn storybook

Note that if you run this example using 5.0.x and DON'T theme, it seems to work OK

@shilman shilman added maintenance User-facing maintenance tasks react patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 10, 2019
@vercel
Copy link

vercel bot commented Apr 10, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-tech-example-for-cra15-support.storybook.now.sh

@shilman shilman requested a review from tmeasday April 10, 2019 03:56
tmeasday
tmeasday reviewed Apr 10, 2019
View reviewed changes
examples/cra-react15/.storybook/config.js

addParameters({
options: {
theme: create({ colorPrimary: 'hotpink', colorSecondary: 'orangered' }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you should comment out the theme to stop this from breaking next? Will still make it much easier to test

Copy link
Member Author

@shilman shilman Apr 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmeasday Unfortunately it still breaks even if I comment that out, I think due to #6435

@ndelangen ndelangen added this to the 5.1.0 milestone Apr 26, 2019
@ndelangen
Copy link
Member

@shilman please take a look it should work now

@ndelangen ndelangen mentioned this pull request Apr 26, 2019
Closed
2 tasks
Hypnosphi added a commit that referenced this pull request May 5, 2019
@Hypnosphi
#6475 add "CRA REACT15" build
87fd9b9
@vercel vercel bot temporarily deployed to staging May 6, 2019 19:28 Inactive
@ndelangen ndelangen force-pushed the tech/example-for-cra15-support branch from 22f3a9c to 06386b3 Compare May 6, 2019 19:34
@vercel vercel bot temporarily deployed to staging May 7, 2019 00:47 Inactive
@ndelangen ndelangen merged commit b19e5bc into next May 7, 2019
@ndelangen ndelangen deleted the tech/example-for-cra15-support branch May 7, 2019 14:54
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday left review comments

@ndelangen ndelangen ndelangen approved these changes

@danielduan danielduan Awaiting requested review from danielduan

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@igor-dv igor-dv Awaiting requested review from igor-dv

@usulpro usulpro Awaiting requested review from usulpro

@alterx alterx Awaiting requested review from alterx

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees

@shilman shilman

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shilman @ndelangen @tmeasday @Hypnosphi