Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overriding webpack loaders example #6463

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Fix overriding webpack loaders example #6463

merged 1 commit into from
Apr 9, 2019

Conversation

vivcogit
Copy link

@vivcogit vivcogit commented Apr 9, 2019

Issue: none

What I did

Fix example to actual structure webpack's config

How to test

Create a storybook with custom webpack config like at example

shilman
shilman requested changes Apr 9, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above ⬆️

docs/src/pages/configurations/custom-webpack-config/index.md Outdated Show resolved Hide resolved
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 9, 2019
@shilman shilman changed the title Update merging webpack loaders example Fix merging webpack loaders example Apr 9, 2019
@shilman shilman changed the title Fix merging webpack loaders example Fix overriding webpack loaders example Apr 9, 2019
@shilman shilman merged commit 6c9f6d5 into storybookjs:master Apr 9, 2019
@shilman shilman added this to the 5.0.x milestone Apr 9, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 28, 2019
shilman added a commit that referenced this pull request Apr 28, 2019
@shilman
Merge pull request #6463 from vivcogit/patch-3
cb83e7a 
Fix overriding webpack loaders example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen ndelangen is a code owner

Assignees
No one assigned
Labels
configuration babel / webpack documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@vivcogit @shilman