Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update migration.md with vue changes introduced in sb5 #6447

Merged
merged 1 commit into from
Apr 7, 2019
Merged

update migration.md with vue changes introduced in sb5 #6447

merged 1 commit into from
Apr 7, 2019

Conversation

backbone87
Copy link
Contributor

Issue:

What I did

Update migration guide for Vue usage in SB5

@backbone87 backbone87 added documentation cleanup Minor cleanup style change that won't show up in release changelog labels Apr 7, 2019
@backbone87 backbone87 requested a review from shilman April 7, 2019 15:34
@backbone87 backbone87 mentioned this pull request Apr 7, 2019
Closed
shilman
shilman approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hero 💯

@shilman shilman merged commit 704756e into storybookjs:master Apr 7, 2019
@shilman shilman removed the cleanup Minor cleanup style change that won't show up in release changelog label Apr 14, 2019
shilman
shilman reviewed Apr 15, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @backbone87, this is great! 🥇

@shilman shilman added vue patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 15, 2019
@shilman shilman added this to the 5.0.x milestone Apr 15, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 8, 2019
shilman added a commit that referenced this pull request May 8, 2019
@shilman
Merge pull request #6447 from backbone87/vue-sb5-migration
e851102 
update migration.md with vue changes introduced in sb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch vue
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@backbone87 @shilman