Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated info on Theme's doc #6446

Merged

Conversation

lonyele
Copy link
Member

@lonyele lonyele commented Apr 7, 2019

From storybook v5, name and url are deprecated and moved to theme object with brandTitle, brandUrl. It is working now since name, url are backward compatibility until 6.0. It would be better if it is removed from the doc for less confusion.

What I did

I removed name key/value on arguments of addParameter()

How to test

  • Is this testable with Jest or Chromatic screenshots? NO
  • Does this need a new example in the kitchen sink apps? NO
  • Does this need an update to the documentation? YES

From storybook v5, `name` and `url` are deprecated and moved to `theme` object. It is working now since `name, url` are backward compatibility until 6.0    It would be better if it is removed from the doc for less confusion.
@vercel
Copy link

vercel bot commented Apr 7, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-lonyele-fix-remove-depre.storybook.now.sh

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2019

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 75b562d

@ndelangen ndelangen self-assigned this Apr 11, 2019
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #6446 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6446   +/-   ##
=======================================
  Coverage   41.04%   41.04%           
=======================================
  Files         613      613           
  Lines        8454     8454           
  Branches      378      378           
=======================================
  Hits         3470     3470           
  Misses       4929     4929           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ffaac...75b562d. Read the comment docs.

@ndelangen ndelangen merged commit cb80893 into storybookjs:next Apr 11, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 11, 2019
@shilman shilman added this to the 5.0.x milestone Apr 11, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 12, 2019
shilman pushed a commit that referenced this pull request Apr 12, 2019
…heme-doc

Remove deprecated info on Theme's doc
@lonyele lonyele deleted the fix/remove-deprecated-info-on-theme-doc branch August 13, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants