Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate addon-options to typescript #6428

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Conversation

kroeder
Copy link
Member

@kroeder kroeder commented Apr 4, 2019

Issue: #5030

What I did

Migrate addon-options to TS

@vercel
Copy link

vercel bot commented Apr 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-ts-migration-addon-options.storybook.now.sh

@kroeder kroeder added addon: options maintenance User-facing maintenance tasks typescript labels Apr 4, 2019
@kroeder
Copy link
Member Author

kroeder commented Apr 4, 2019

This package is deprecated - should I bother about typings for it? I just did a quick renaming and "any" everything that turned red

@ndelangen
Copy link
Member

I'm fine with typing it for now

Just don't put large amounts of time in it.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #6428 into next will decrease coverage by 3.89%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next    #6428     +/-   ##
=========================================
- Coverage   41.01%   37.12%   -3.9%     
=========================================
  Files         613      650     +37     
  Lines        8460    10172   +1712     
  Branches      377      391     +14     
=========================================
+ Hits         3470     3776    +306     
- Misses       4937     6336   +1399     
- Partials       53       60      +7
Impacted Files Coverage Δ
addons/options/src/register.ts 0% <ø> (ø)
addons/options/src/constants.ts 0% <ø> (ø)
addons/options/src/index.ts 0% <0%> (ø)
addons/options/src/public_api.ts 0% <0%> (ø)
addons/actions/src/preview/action.ts 90.9% <0%> (-9.1%) ⬇️
addons/ondevice-knobs/src/types/Date.js 0% <0%> (ø) ⬆️
app/polymer/src/client/index.js 0% <0%> (ø) ⬆️
app/html/standalone.js 0% <0%> (ø) ⬆️
lib/core/src/server/config.js 0% <0%> (ø) ⬆️
lib/core/src/server/cli/prod.js 0% <0%> (ø) ⬆️
... and 326 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2564834...0e1478e. Read the comment docs.

@@ -17,6 +17,7 @@
},
"license": "MIT",
"main": "dist/index.js",
"types": "dist/public_api.d.ts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not dist/index.d.ts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this package has multiple files with exports - I then use public_api.d.ts as entry point and export everything from one file

@ndelangen ndelangen merged commit 05610b9 into next Apr 5, 2019
@ndelangen ndelangen deleted the ts-migration/addon-options branch April 5, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: options maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants