-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate addon-options to typescript #6428
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-ts-migration-addon-options.storybook.now.sh |
This package is deprecated - should I bother about typings for it? I just did a quick renaming and "any" everything that turned red |
I'm fine with typing it for now Just don't put large amounts of time in it. |
Codecov Report
@@ Coverage Diff @@
## next #6428 +/- ##
=========================================
- Coverage 41.01% 37.12% -3.9%
=========================================
Files 613 650 +37
Lines 8460 10172 +1712
Branches 377 391 +14
=========================================
+ Hits 3470 3776 +306
- Misses 4937 6336 +1399
- Partials 53 60 +7
Continue to review full report at Codecov.
|
@@ -17,6 +17,7 @@ | |||
}, | |||
"license": "MIT", | |||
"main": "dist/index.js", | |||
"types": "dist/public_api.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not dist/index.d.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this package has multiple files with exports - I then use public_api.d.ts as entry point and export everything from one file
Issue: #5030
What I did
Migrate addon-options to TS