Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate @storybook/addon-jest to TS #6403

Merged
merged 13 commits into from
Apr 8, 2019
Prev Previous commit
Next Next commit
chore: remove prop-types in addons/jest
Anton Savoskin committed Apr 4, 2019
commit 9654bb1c24c24104ec670bed5b4df7dcad0830ec
4 changes: 0 additions & 4 deletions addons/jest/src/components/Message.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/* tslint:disable:object-literal-sort-keys */

import PropTypes from 'prop-types';
import React from 'react';
import { styled } from '@storybook/theming';
import colors from '../colors';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these colours should come from the theme if possible

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't find similar colors in lib/theming/src/base.ts

@@ -205,8 +204,5 @@ const Message = ({ msg }: MessageProps) => {

return <Pre>{data}</Pre>;
};
Message.propTypes = {
msg: PropTypes.string.isRequired,
};

export default Message;