Refactor story_store #6382
Merged
Refactor story_store #6382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't touch URL - only emit events, don't listen on them - add tests
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-tech-story-store-refactor.storybook.now.sh |
ndelangen
requested changes
Apr 2, 2019
|
@shilman want me to pick this up? I think more merge-conflicts will be happening if you let this collect dust some more. |
|
@ndelangen No worries, I'll update it this weekend. |
|
ping @shilman |
|
Roger. Will update this with the changes we made together the other day. Also found a bug in our work & fixed in my branch 😉 |
|
@ndelangen @tmeasday @igor-dv First PR for #7101 |
ndelangen
approved these changes
Jun 17, 2019
|
@Jessica-Koch heads-up, some changes incoming on client-api (which you're currently migrating to typescript). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7101
What I did
Refactor
story_storein prep for docs mode:All of these changes are positive independent of docs mode.