Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify labels for options #6334

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Clarify labels for options #6334

merged 1 commit into from
Mar 28, 2019

Conversation

coryhouse
Copy link
Contributor

Issue:

What I did

I clarified the setup docs

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

shilman
shilman approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 28, 2019
@shilman shilman added this to the 5.0.x milestone Mar 28, 2019
@shilman shilman merged commit 67dff35 into storybookjs:master Mar 28, 2019
@coryhouse coryhouse deleted the patch-4 branch March 29, 2019 00:16
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 29, 2019
shilman added a commit that referenced this pull request Mar 29, 2019
@shilman
Merge pull request #6334 from coryhouse/patch-4
5161f46 
Clarify labels for options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@thomasbertet thomasbertet Awaiting requested review from thomasbertet thomasbertet is a code owner

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@coryhouse @shilman