Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused code #6324

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Clean up unused code #6324

merged 1 commit into from
Mar 28, 2019

Conversation

mikach
Copy link
Contributor

@mikach mikach commented Mar 27, 2019

What I did

Removed unused code from Typescript Setup docs

@ndelangen ndelangen changed the base branch from master to next March 27, 2019 21:57
@ndelangen ndelangen self-assigned this Mar 27, 2019
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #6324 into next will decrease coverage by 3.21%.
The diff coverage is 26.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6324      +/-   ##
==========================================
- Coverage   38.27%   35.06%   -3.22%     
==========================================
  Files         648      636      -12     
  Lines        9844     9366     -478     
  Branches      387     1320     +933     
==========================================
- Hits         3768     3284     -484     
+ Misses       6016     5436     -580     
- Partials       60      646     +586
Impacted Files Coverage Δ
lib/ui/src/core/context.js 9.09% <ø> (ø)
app/react/src/demo/Welcome.js 0% <ø> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <ø> (ø)
lib/core/src/server/common/babel.js 0% <ø> (ø) ⬆️
lib/ui/src/settings/about.js 92.59% <ø> (ø) ⬆️
addons/viewport/src/Tool.js 0% <ø> (ø) ⬆️
app/angular/src/demo/welcome.component.ts 0% <ø> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarHeading.js 88.46% <ø> (-0.43%) ⬇️
lib/core/src/server/cli/dev.js 0% <ø> (ø) ⬆️
addons/info/src/components/Story.js 88.34% <ø> (ø) ⬆️
... and 374 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30f04a...f25afcf. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #6324 into next will decrease coverage by 3.21%.
The diff coverage is 26.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6324      +/-   ##
==========================================
- Coverage   38.27%   35.06%   -3.22%     
==========================================
  Files         648      636      -12     
  Lines        9844     9366     -478     
  Branches      387     1320     +933     
==========================================
- Hits         3768     3284     -484     
+ Misses       6016     5436     -580     
- Partials       60      646     +586
Impacted Files Coverage Δ
lib/ui/src/core/context.js 9.09% <ø> (ø)
app/react/src/demo/Welcome.js 0% <ø> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <ø> (ø)
lib/core/src/server/common/babel.js 0% <ø> (ø) ⬆️
lib/ui/src/settings/about.js 92.59% <ø> (ø) ⬆️
addons/viewport/src/Tool.js 0% <ø> (ø) ⬆️
app/angular/src/demo/welcome.component.ts 0% <ø> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarHeading.js 88.46% <ø> (-0.43%) ⬇️
lib/core/src/server/cli/dev.js 0% <ø> (ø) ⬆️
addons/info/src/components/Story.js 88.34% <ø> (ø) ⬆️
... and 374 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30f04a...f25afcf. Read the comment docs.

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 28, 2019
@shilman shilman added this to the 5.0.x milestone Mar 28, 2019
@shilman shilman merged commit 46b3c87 into storybookjs:next Mar 28, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 29, 2019
shilman added a commit that referenced this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants