Fix {name, url} options deprecation message #6314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it's misleading
shilman
added
the
patch:yes
Codecov Report
@@ Coverage Diff @@
## next #6314 +/- ##
=======================================
Coverage 38.27% 38.27%
=======================================
Files 648 648
Lines 9844 9844
Branches 387 387
=======================================
Hits 3768 3768
Misses 6016 6016
Partials 60 60
Continue to review full report at Codecov.
|
Keraito
approved these changes
Mar 27, 2019
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Mar 29, 2019
Fix {name, url} options deprecation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's misleading