-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Fixed contrast of Show Info button in addon-info #6301
bug: Fixed contrast of Show Info button in addon-info #6301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you provide a screenshot of the new color or that the a11y report doesn't fail anymore for verifications?
Codecov Report
@@ Coverage Diff @@
## next #6301 +/- ##
=======================================
Coverage 38.29% 38.29%
=======================================
Files 648 648
Lines 9839 9839
Branches 387 387
=======================================
Hits 3768 3768
Misses 6011 6011
Partials 60 60
Continue to review full report at Codecov.
|
@Keraito No problem. Here's the color before, with accessibility violations. And here's after, with no violations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trevoreyre ! Looks great 👍
bug: Fixed contrast of Show Info button in addon-info
Issue: #6256
What I did
Updated the background color of the Show Info button so it passes accessibility checks from addon-a11y.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.