Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fixed contrast of Show Info button in addon-info #6301

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

trevoreyre
Copy link
Contributor

Issue: #6256

What I did

Updated the background color of the Show Info button so it passes accessibility checks from addon-a11y.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman added addon: info bug patch:yes Bugfix & documentation PR that need to be picked to main branch accessibility labels Mar 26, 2019
Copy link
Contributor

@Keraito Keraito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you provide a screenshot of the new color or that the a11y report doesn't fail anymore for verifications?

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #6301 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6301   +/-   ##
=======================================
  Coverage   38.29%   38.29%           
=======================================
  Files         648      648           
  Lines        9839     9839           
  Branches      387      387           
=======================================
  Hits         3768     3768           
  Misses       6011     6011           
  Partials       60       60
Impacted Files Coverage Δ
addons/info/src/components/Story.js 88.34% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb9047...a2d211d. Read the comment docs.

@trevoreyre
Copy link
Contributor Author

@Keraito No problem. Here's the color before, with accessibility violations.

Screen Shot 2019-03-28 at 3 42 51 PM

And here's after, with no violations.

Screen Shot 2019-03-28 at 3 45 14 PM

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trevoreyre ! Looks great 👍

@shilman shilman merged commit af80955 into storybookjs:next Mar 29, 2019
shilman added a commit that referenced this pull request Mar 29, 2019
Somehow missed in #6301
@trevoreyre trevoreyre deleted the 6256-fix-addon-info-a11y branch March 29, 2019 16:27
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 1, 2019
shilman added a commit that referenced this pull request Apr 1, 2019
bug: Fixed contrast of Show Info button in addon-info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility addon: info bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants