Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX storybook having a incompatible version of webpack with vue-cli #6259

Merged
merged 3 commits into from
Mar 25, 2019

Conversation

ndelangen
Copy link
Member

Issue: https://stackoverflow.com/a/53630702

What I did

CHANGE the required version of webpack so it's more likely to be compatible with the users installed version.

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #6259 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6259   +/-   ##
=======================================
  Coverage   38.12%   38.12%           
=======================================
  Files         646      646           
  Lines        9698     9698           
  Branches      366      366           
=======================================
  Hits         3697     3697           
  Misses       5944     5944           
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f95620...e6f7439. Read the comment docs.

Copy link
Contributor

@backbone87 backbone87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but why do the apps also require webpack and do not rely on cores webpack constraint?

@ndelangen
Copy link
Member Author

lgtm, but why do the apps also require webpack and do not rely on cores webpack constraint?

Yeah we should probably use the one from core

@ndelangen ndelangen merged commit 0f44caf into next Mar 25, 2019
@ndelangen ndelangen deleted the tech/widen-required-webpack-version branch March 25, 2019 17:17
@backbone87
Copy link
Contributor

@ndelangen does this also go into 5.0.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants