Update type definition for panelPosition to enum of strings #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
ui
documentation
patch:yes
ndelangen
approved these changes
Mar 25, 2019
Codecov Report
@@ Coverage Diff @@
## next #6254 +/- ##
=======================================
Coverage 38.16% 38.16%
=======================================
Files 645 645
Lines 9655 9655
Branches 355 355
=======================================
Hits 3685 3685
Misses 5915 5915
Partials 55 55Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## next #6254 +/- ##
=======================================
Coverage 38.16% 38.16%
=======================================
Files 645 645
Lines 9655 9655
Branches 355 355
=======================================
Hits 3685 3685
Misses 5915 5915
Partials 55 55Continue to review full report at Codecov.
|
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Mar 26, 2019
Update type definition for panelPosition to enum of strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Updated the type definition in the docs for the
panelPositionconfig. Changed to an enum of strings to show the possible values that can be used ('bottom' & 'right').