Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Fuse.js package instead of fuzzy-search for customizable search threshold #6244

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

mohsinulhaq
Copy link
Contributor

Issue: #5940

What I did

Use Fuse.js for customizing fuzzy search threshold

@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #6244 into next will increase coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6244      +/-   ##
==========================================
+ Coverage   38.16%   38.17%   +<.01%     
==========================================
  Files         645      645              
  Lines        9655     9656       +1     
  Branches      355      355              
==========================================
+ Hits         3685     3686       +1     
  Misses       5915     5915              
  Partials       55       55
Impacted Files Coverage Δ
lib/api/src/version.ts 0% <0%> (ø) ⬆️
lib/ui/src/components/sidebar/treeview/utils.js 84.04% <50%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbec9a0...6df76ef. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #6244 into next will increase coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6244      +/-   ##
==========================================
+ Coverage   38.16%   38.17%   +<.01%     
==========================================
  Files         645      645              
  Lines        9655     9656       +1     
  Branches      355      355              
==========================================
+ Hits         3685     3686       +1     
  Misses       5915     5915              
  Partials       55       55
Impacted Files Coverage Δ
lib/api/src/version.ts 0% <0%> (ø) ⬆️
lib/ui/src/components/sidebar/treeview/utils.js 84.04% <50%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbec9a0...6df76ef. Read the comment docs.

@shilman shilman added bug ui and removed bug labels Mar 23, 2019
@shilman shilman added this to the v5.1.0 milestone Mar 23, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results are looking really good and this is a nice small change. Great work! 👏

@ndelangen ndelangen merged commit 301d578 into storybookjs:next Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants