Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): event bindings, logger import #6238

Merged
merged 1 commit into from
Mar 22, 2019
Merged

fix(tooltip): event bindings, logger import #6238

merged 1 commit into from
Mar 22, 2019

Conversation

Armanio
Copy link
Member

@Armanio Armanio commented Mar 22, 2019

Issue: #6211

Actually, the problem was in incorrect logger import because as any sensitive code wrapped in try/catch block. I fixed import and change catch block for more clear.

What I did

Fix logger import
Catch error bindings

How to test

Install https://github.com/wolfmanstout/vimium in FF
Open any sample
...
Profit!

  • Is this testable with Jest or Chromatic screenshots?
    no
  • Does this need a new example in the kitchen sink apps?
    no
  • Does this need an update to the documentation?
    no

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 22, 2019
@shilman shilman added this to the 5.0.x milestone Mar 22, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🤕

@shilman shilman merged commit 3f01fb8 into storybookjs:next Mar 22, 2019
@Armanio Armanio deleted the fix/tooltip_events branch March 23, 2019 08:28
shilman added a commit that referenced this pull request Mar 23, 2019
fix(tooltip): event bindings, logger import
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug components patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants