Forked CRA support on Windows

[sergeyzwezdin]

Issue: Support for CRA fork packages on Windows (#5801)

What I did

I've added parsing of .bin/react-scripts file to find out actual react-scripts package path.

[codecov]

Codecov Report

Merging #6236 into next will decrease coverage by <.01%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##             next    #6236      +/-   ##
==========================================
- Coverage   38.12%   38.12%   -0.01%     
==========================================
  Files         645      645              
  Lines        9646     9654       +8     
  Branches      355      355              
==========================================
+ Hits         3678     3681       +3     
- Misses       5913     5918       +5     
  Partials       55       55

Impacted Files	Coverage Δ
app/react/src/server/cra-config.js	81.25% <44.44%> (-6.25%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4057939...2540eba. Read the comment docs.

[shilman]

Any chance you can add a unit test for this in cra-config.test.js? This is hard to test without a windows machine and inside our monorepo which doesn't have any CRA-fork apps. But I'd feel a lot better about merging if I knew what the data looked like.

[sergeyzwezdin]

@shilman Hm, I would happy to add that, but I do not understand how to emulate .bin and node_modules folder in the test. If you advise me, I will add it for sure.

[shilman]

@sergeyzwezdin if you look at the existing tests, the fs module is already mocked, so you can make it return whatever you want in your test. Make it return something that looks like what you'd get on the windows machine, and verify that the result of your new code is what you'd expect. Does that make sense? I think you can just follow the patterns that are already in the test file.

[sergeyzwezdin]

@shilman Sounds good. I'll try it tomorrow morning.

[shilman]

Great @sergeyzwezdin. Thanks for your patience on this and I'll get it merged and released on alpha as soon as I'm comfortable with the change.

[sergeyzwezdin]

@shilman Ok, I managed to add the test. It seems everything is 👌now.

[shilman]

Looks super, great job @sergeyzwezdin! 🚀 I'll release this on alpha today (and post on the issue) and then will patch it back into master once you test it out on the alpha. Sound ok?

[sergeyzwezdin]

@shilman yep, sounds cool! 👍🏼

[shilman]

@sergeyzwezdin ready for testing 🔍

[sergeyzwezdin]

@shilman Works like a charm. When do you plan to release it?

[shilman]

Super. I've been doing alpha releases every other day (ish) and stable releases once or twice a week (ish) so probably tomorrow. I'll post on the issue when it's live

[sergeyzwezdin]

Cool! Waiting for that then. Thank you for your help.