Make update notifications much less aggressive #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
maintenance
shilman
requested review from
Hypnosphi,
igor-dv,
ndelangen and
tmeasday
as code owners
shilman
changed the title
shilman
changed the title
ndelangen
approved these changes
Mar 18, 2019
|
Nice! It makes a lot of sense. |
tmeasday
reviewed
Mar 18, 2019
|
@tmeasday Correct. You'd get notified on 4.1.0 |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 18, 2019
Make update notifications much less aggressive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A, see https://twitter.com/amcdnl/status/1105427759738822656
What I did
Change update heuristics to not display on patches and prereleases, since we release all the time and it can get annoying.
Also don't display notifications in production mode, since the user can't necessarily do anything about it.
Preserve the rest, so users can see updates if they explicitly navigate to the about page.
How to test