Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vue "manual setup" steps #6108

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Conversation

breadadams
Copy link
Contributor

Issue: #4475

What I did

Include babel-preset-vue in the required dependency instructions

+ Include `babel-preset-vue` in the required dependency instructions
@breadadams
Copy link
Contributor Author

On a side note, this dependency should probably be replaced with @vue/babel-preset-app (and therefore the docs would need readjusting).

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this 🙏

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 15, 2019
@shilman shilman added this to the 5.0.x milestone Mar 15, 2019
@shilman shilman merged commit 7b261db into storybookjs:next Mar 15, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 16, 2019
shilman added a commit that referenced this pull request Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants