Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]Error message when removing value from number knob #6043

Merged
merged 1 commit into from
Mar 12, 2019
Merged

[bug]Error message when removing value from number knob #6043

merged 1 commit into from
Mar 12, 2019

Conversation

toshi1127
Copy link
Contributor

@toshi1127 toshi1127 commented Mar 12, 2019 •
edited by shilman
Loading

Issue: #5912

When removing the value from the "number" knob, following error appears in the console:

What I did

Since number may be null, I assigned '' at that time.

before after
スクリーンショット 2019-03-12 21 45 31 スクリーンショット 2019-03-12 21 46 05

How to test

  • Is this testable with Jest or Chromatic screenshots? I'm not sure what is the proper way to do it here.
  • Does this need a new example in the kitchen sink apps? No.
  • Does this need an update to the documentation? No.

@shilman shilman added this to the 5.0.x milestone Mar 12, 2019
shilman
shilman approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!! 🥇

@shilman shilman merged commit 2ac8ae6 into storybookjs:next Mar 12, 2019
@shilman shilman mentioned this pull request Mar 12, 2019
Closed
@metasean metasean mentioned this pull request Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@theinterned theinterned Awaiting requested review from theinterned

Assignees
No one assigned
Labels
addon: knobs bug
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@toshi1127 @shilman