-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (addon/backgrounds): addon panel doesn't hide #6042
Conversation
Instead of turning the preview transparent, addon-backgrounds should set the background color to the theme's default. I added the background import and set background.content as the replacement for all transparent returns
This would make the preview background not respect the user's theme. |
Codecov Report
@@ Coverage Diff @@
## next #6042 +/- ##
==========================================
- Coverage 37.65% 35.78% -1.87%
==========================================
Files 642 648 +6
Lines 9388 9520 +132
Branches 1364 1380 +16
==========================================
- Hits 3535 3407 -128
- Misses 5293 5536 +243
- Partials 560 577 +17
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## next #6042 +/- ##
=======================================
Coverage 37.65% 37.65%
=======================================
Files 642 642
Lines 9388 9388
Branches 1364 1364
=======================================
Hits 3535 3535
Misses 5293 5293
Partials 560 560
Continue to review full report at Codecov.
|
…le, when they are not supposed to be Thanks to glitchperfect's #6042
I refactored this addon quite a bit in my PR for migrating the core to typescript. I incorporated this fix into that PR: 5592373 I also made sure the user's theme is respected. |
I just pushed a little fix to this PR, because I want @GlitchPerfect to have this PR merged. I really appreciate the effort. I think this should be good to merge now. I'll deal with the merge conflict in my api branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix (addon/backgrounds): addon panel doesn't hide
Fixes #6041
Instead of turning the preview transparent, addon-backgrounds should set the background color to the theme's default.
I added the background import and set background.content as the replacement for all transparent returns