Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(addons): add hint about addon tab order #6021

Merged
merged 2 commits into from
Mar 16, 2019
Merged

docs(addons): add hint about addon tab order #6021

merged 2 commits into from
Mar 16, 2019

Conversation

HerrBertling
Copy link

@HerrBertling HerrBertling commented Mar 11, 2019

Issue: #6019

which I missed and I guess would be rather helpful for others searching for this.

What I did

Added a short paragraph about how to change the tab order. I also inserted some headlines to structure the page a bit more. Also, because of the injected paragraph, I changed the sentence about the usage since it now lacked context.

How to test

  1. Start the docs subfolder as described in its readme.
  2. Navigate to "Using addons".
  3. Read the sentence 😆

which I missed and I guess would be rather helpful
for others searching for this.

fixes #6019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tho I'm not sure this still makes sense in SB5 where the notes addon is a TAB type? @ndelangen?

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought I think this doesn't make sense in SB5 since addon-notes doesn't show up in the addons panel anymore. Can you use an example like knobs that does? cc @ndelangen

@HerrBertling
Copy link
Author

HerrBertling commented Mar 12, 2019

Can you use an example like knobs that does?

Sure! That's also what I actually have in my setup – actions & knobs 😊

@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #6021 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6021   +/-   ##
=======================================
  Coverage   34.92%   34.92%           
=======================================
  Files         648      648           
  Lines        9517     9517           
  Branches     1352     1352           
=======================================
  Hits         3324     3324           
  Misses       5576     5576           
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f94f5b...acbf939. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #6021 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6021   +/-   ##
=======================================
  Coverage   34.92%   34.92%           
=======================================
  Files         648      648           
  Lines        9517     9517           
  Branches     1352     1352           
=======================================
  Hits         3324     3324           
  Misses       5576     5576           
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f94f5b...38f9059. Read the comment docs.

@shilman shilman merged commit 7faf486 into storybookjs:next Mar 16, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 16, 2019
@shilman shilman added this to the 5.0.x milestone Mar 16, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 16, 2019
shilman added a commit that referenced this pull request Mar 16, 2019
docs(addons): add hint about addon tab order
@HerrBertling HerrBertling deleted the 6019-docs-addons-tab-order branch March 16, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants