-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(addons): add hint about addon tab order #6021
docs(addons): add hint about addon tab order #6021
Conversation
which I missed and I guess would be rather helpful for others searching for this. fixes #6019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM tho I'm not sure this still makes sense in SB5 where the notes addon is a TAB
type? @ndelangen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought I think this doesn't make sense in SB5 since addon-notes doesn't show up in the addons panel anymore. Can you use an example like knobs
that does? cc @ndelangen
Sure! That's also what I actually have in my setup – actions & knobs 😊 |
Codecov Report
@@ Coverage Diff @@
## next #6021 +/- ##
=======================================
Coverage 34.92% 34.92%
=======================================
Files 648 648
Lines 9517 9517
Branches 1352 1352
=======================================
Hits 3324 3324
Misses 5576 5576
Partials 617 617 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## next #6021 +/- ##
=======================================
Coverage 34.92% 34.92%
=======================================
Files 648 648
Lines 9517 9517
Branches 1352 1352
=======================================
Hits 3324 3324
Misses 5576 5576
Partials 617 617 Continue to review full report at Codecov.
|
docs(addons): add hint about addon tab order
Issue: #6019
which I missed and I guess would be rather helpful for others searching for this.
What I did
Added a short paragraph about how to change the tab order. I also inserted some headlines to structure the page a bit more. Also, because of the injected paragraph, I changed the sentence about the usage since it now lacked context.
How to test