Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-a11y: add 'incomplete' tab #5984

Merged
merged 2 commits into from
Mar 9, 2019
Merged

Addon-a11y: add 'incomplete' tab #5984

merged 2 commits into from
Mar 9, 2019

Conversation

Armanio
Copy link
Member

@Armanio Armanio commented Mar 9, 2019

Issue: #5782

What I did

Add 'incomplete' tab in a11y addon
Fix cra-kitchen-sink example (turn on addon)

How to test

  • Is this testable with Jest or Chromatic screenshots?
    no
  • Does this need a new example in the kitchen sink apps?
    yes
  • Does this need an update to the documentation?
    no

@shilman
Copy link
Member

shilman commented Mar 9, 2019

Tested -- works great!

@shilman shilman merged commit 1756f62 into storybookjs:next Mar 9, 2019
@shilman shilman changed the title feta(a11y): add 'incomplete' tab Addon-a11y: add 'incomplete' tab Mar 9, 2019
@Armanio Armanio deleted the feat/a11y_incomplete branch March 9, 2019 14:55
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants