Change viewport styling to more closely match v4 #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Styling for addon-viewport iframe was a 10px black border which was a little intrusive when working on stories. This commit changes the iframe style to a more familiar style that mimics v4 with horizontal centering and a subtle box-shadow.
shilman
added
maintenance
|
Looks great!!! |
Codecov Report
@@ Coverage Diff @@
## next #5979 +/- ##
=======================================
Coverage 34.91% 34.91%
=======================================
Files 648 648
Lines 9496 9496
Branches 1377 1377
=======================================
Hits 3316 3316
Misses 5563 5563
Partials 617 617
Continue to review full report at Codecov.
|
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 11, 2019
Change viewport styling to more closely match v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5965
What I did
Styling for addon-viewport iframe was a 10px black border which was a
little intrusive when working on stories. This commit changes the iframe
style to a more familiar style that mimics v4 with horizontal centering
and a subtle box-shadow.
How to test
The changes are reflected in the
Viewportstories being tested in Chromatic.