Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example of setting defaultViewport per story #5967

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Fix example of setting defaultViewport per story #5967

merged 1 commit into from
Mar 9, 2019

Conversation

no23reason
Copy link

@no23reason no23reason commented Mar 8, 2019 •
edited
Loading

Issue: #5968

What I did

I fixed the example in the README.

@no23reason no23reason requested a review from saponifi3d as a code owner March 8, 2019 15:40
@codecov
Copy link

codecov bot commented Mar 8, 2019 •
edited
Loading

Codecov Report

Merging #5967 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5967   +/-   ##
=======================================
  Coverage   34.38%   34.38%           
=======================================
  Files         636      636           
  Lines        9374     9374           
  Branches     1323     1323           
=======================================
  Hits         3223     3223           
  Misses       5508     5508           
  Partials      643      643

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baee8af...e2a2067. Read the comment docs.

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 8, 2019
shilman
shilman approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@shilman shilman merged commit ac43c9e into storybookjs:master Mar 9, 2019
@shilman shilman mentioned this pull request Mar 9, 2019
Closed
@tmeasday
Copy link
Member

tmeasday commented Mar 9, 2019

🙏

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 12, 2019
shilman added a commit that referenced this pull request Mar 12, 2019
@shilman
Merge pull request #5967 from no23reason/patch-3
7a6c1fa 
Fix example of setting defaultViewport per story
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@saponifi3d saponifi3d Awaiting requested review from saponifi3d saponifi3d is a code owner

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no23reason @tmeasday @shilman